Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/allow implicit swaps not handled correctly #526

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Bugfix/allow implicit swaps not handled correctly #526

merged 3 commits into from
Oct 28, 2024

Conversation

yao-cqc
Copy link
Contributor

@yao-cqc yao-cqc commented Oct 28, 2024

Description

Please summarise the changes.

Related issues

Fixes #515

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@yao-cqc yao-cqc marked this pull request as ready for review October 28, 2024 16:50
@yao-cqc yao-cqc requested a review from cqc-alec October 28, 2024 16:50
@yao-cqc yao-cqc merged commit a06bdd8 into main Oct 28, 2024
12 checks passed
@yao-cqc yao-cqc deleted the bugfix/`allow_implicit_swaps`-not-handled-correctly branch October 28, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqc-alec cqc-alec cqc-alec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow_implicit_swaps only works for optimisation level 0
2 participants
@yao-cqc @cqc-alec